Skip to content

refactor: Remove ngcc from extension #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

refactor: Remove ngcc from extension #1862

merged 2 commits into from
Feb 23, 2023

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Feb 15, 2023

NGCC is being removed in Angular v16. The language service should not longer attempt to run it. angular/angular-cli#24720 As a result, we can now set the support for running in untrusted workspaces to "true" since we don't have to execute ngcc from the node_modules folder.

@atscott atscott added the target: major This PR is targeted for the next major release label Feb 15, 2023
@atscott atscott force-pushed the noNgcc branch 4 times, most recently from 8f11290 to 820a049 Compare February 17, 2023 17:31
NGCC is being removed in Angular v16. The language service should not
longer attempt to run it. angular/angular-cli#24720
As a result, we can now set the support for running in untrusted
workspaces to "true" since we don't have to execute ngcc from the
`node_modules` folder.
@atscott atscott marked this pull request as ready for review February 22, 2023 22:10
@atscott atscott requested review from devversion and alan-agius4 and removed request for devversion February 23, 2023 00:58
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge Ready to merge label Feb 23, 2023
@atscott atscott merged commit 3d179de into angular:main Feb 23, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants