Configure typed/untyped converstion from the CLI and default to typed #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,9 @@ const internalExternsFileName = 'tsickle_externs.js'; | |||
| interface Settings { | |||
| /** If provided, path to save externs to. */ | |||
| externsPath?: string; | |||
|
|
|||
| /** If provided, convert every type to the Closure {?} type */ | |||
| isTyped: boolean; | |||
There was a problem hiding this comment.
The comment seems to say the opposite of what the variable name indicates, maybe just a typo.
I think this would be better expressed as an optional "untyped" field, so that it can default to falsey (either unprovided or false). At least, that's how it works in the underlying tsickle library.
There was a problem hiding this comment.
Nice catch. That's what I get for copy pasting. I'll change it to untyped to keep it the same as the tsickle library.
|
Ah. So that's why that was there :) I prefer having a flag, so users can at least try to use typed mode without having to modify the source. |
tsickle was defaulting to untyped conversions, i.e., every TypeScript type
was converted to the Closure {?} type. Now it defaults to typed and allows
the user to configure whether types should be converted to {?} or an actual
type.
jjudd
force-pushed
the
typed-configuration-cli
branch
from
972d283 to
b58235a
Compare
|
Makes sense, thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsickle was defaulting to untyped conversions, i.e., every TypeScript type
was converted to the Closure {?} type. Now it defaults to typed and allows
the user to configure whether types should be converted to {?} or an actual
type.