Configure typed/untyped converstion from the CLI and default to typed

tsickle was defaulting to untyped conversions, i.e., every TypeScript type
was converted to the Closure {?} type. Now it defaults to typed and allows
the user to configure whether types should be converted to {?} or an actual
type.

Author: James Judd

src/main.ts

@@ -19,6 +19,9 @@ const internalExternsFileName = 'tsickle_externs.js';
 interface Settings {
   /** If provided, path to save externs to. */
   externsPath?: string;
+
+  /** If provided, convert every type to the Closure {?} type */
+  isTyped: boolean;
 }
 
 function usage() {
@@ -29,6 +32,7 @@ example:
 
 tsickle flags are:
   --externs=PATH     save generated Closure externs.js to PATH
+  --untyped          convert every type in TypeScript to the Closure {?} type
 `);
 }
 
@@ -37,7 +41,7 @@ tsickle flags are:
  * the arguments to pass on to tsc.
  */
 function loadSettingsFromArgs(args: string[]): {settings: Settings, tscArgs: string[]} {
-  let settings: Settings = {};
+  let settings: Settings = {isTyped: true};
   let parsedArgs = minimist(args);
   for (let flag of Object.keys(parsedArgs)) {
     switch (flag) {
@@ -49,6 +53,9 @@ function loadSettingsFromArgs(args: string[]): {settings: Settings, tscArgs: str
       case 'externs':
         settings.externsPath = parsedArgs[flag];
         break;
+      case 'untyped':
+        settings.isTyped = false;
+        break;
       case '_':
         // This is part of the minimist API, and holds args after the '--'.
         break;
@@ -136,7 +143,7 @@ function createSourceReplacingCompilerHost(
  * Compiles TypeScript code into Closure-compiler-ready JS.
  * Doesn't write any files to disk; all JS content is returned in a map.
  */
-function toClosureJS(options: ts.CompilerOptions, fileNames: string[]):
+function toClosureJS(options: ts.CompilerOptions, fileNames: string[], isTyped: boolean):
     {jsFiles?: {[fileName: string]: string}, errors?: ts.Diagnostic[]} {
   // Parse and load the program without tsickle processing.
   // This is so:
@@ -148,10 +155,8 @@ function toClosureJS(options: ts.CompilerOptions, fileNames: string[]):
     return {errors};
   }
 
-  // TODO(evanm): let the user configure tsickle options via the command line.
-  // Or, better, just make tsickle always work without needing any options.
   const tsickleOptions: tsickle.Options = {
-    untyped: true,
+    untyped: !isTyped,
   };
 
   // Process each input file with tsickle and save the output.
@@ -207,7 +212,7 @@ function main(args: string[]) {
 
   // Run tsickle+TSC to convert inputs to Closure JS files.
   let jsFiles: {[fileName: string]: string};
-  ({jsFiles, errors} = toClosureJS(options, fileNames));
+  ({jsFiles, errors} = toClosureJS(options, fileNames, settings.isTyped));
   if (errors && errors.length > 0) {
     console.error(tsickle.formatDiagnostics(errors));
     process.exit(1);