Remove closure compilation from the CLI #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,8 +67,8 @@ function loadSettingsFromArgs(args: string[]): {settings: Settings, tscArgs: str | |||
| process.exit(1); | |||
| } | |||
| } | |||
| if (!settings.outputPath && !settings.externsPath) { | |||
| console.error('must specify --output or --externs path'); | |||
| if (!settings.externsPath) { | |||
There was a problem hiding this comment.
Because this is required, it might be worth making this an argument instead of an option. Alternatively, do not make it required.
|
This would resolve #153, it does not have the rest of the enhancements discussed there, but this gets the npm package working without needing the google-closure-compiler installed. |
This removes the need for google-closure-compiler to be a dependency. Now it can be a dev dependency and the CLI should just work when downloaded from npm. Because the closure compiler has been removed, temporary files are always output because tsickle is now a wrapper around the TypeScript compiler.
jjudd
force-pushed
the
remove-closure-compilation
branch
from
2c4bf81 to
957ec2e
Compare
| fs.writeFileSync(fileName, jsFiles[fileName]); | ||
| } | ||
| for (let fileName of Object.keys(jsFiles)) { | ||
| fs.writeFileSync(fileName, jsFiles[fileName]); |
There was a problem hiding this comment.
Does this always write the files next to the .ts files? Or does it obey outDir? Just curious.
There was a problem hiding this comment.
As far as I can tell, it obeys all the output rules of the TypeScript compiler. We're using outDir without any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for google-closure-compiler to be a dependency. Now
it can be a dev dependency and the CLI should just work when downloaded
from npm.