Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

test(travis): added travis_retry for testonsauce.sh #790

Closed
wants to merge 1 commit into from

Conversation

elgalu
Copy link
Contributor

@elgalu elgalu commented May 7, 2014

travis_retry checks the return code of a command, in this case testonsauce.sh, retrying up to 3 times if the return code is non-zero.

This will help avoid false positives errored builds due to unrelated timing issues with Sauce Labs.

@elgalu elgalu added cla: yes and removed cla: no labels May 7, 2014
@juliemr
Copy link
Member

juliemr commented May 16, 2014

didn't know about that, very cool! I'm concerned that this would make the suite take a very long time for legitimate failures, however. (It's already 10 minutes, I'd hate to have it take half an hour).

I'll be exploring some of the saucelabs issues this week - give me a bit to look into that and see if there's other ways to address this before we resort to a full retry :) I'll leave this open though.

@juliemr
Copy link
Member

juliemr commented May 23, 2014

Now that IE 11 is added and I think we've addressed some of the flakes, I'd prefer to find flakes rather than mask them, so I'm gonna close this one.

Thanks for teaching me about travis_retry though!

@juliemr juliemr closed this May 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants