Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

test(multi): added Internet Explorer 11 to ciConf.js (SauceLabs) #777

Closed
wants to merge 3 commits into from

Conversation

elgalu
Copy link
Contributor

@elgalu elgalu commented May 6, 2014

I think we should be testing protractor against IE for every change since it's still a very active browser and I also think IE11 is a good start since is a modern browser that auto-updates plus angular 2.0 will support it

Side note, running npm test against IE11 allowed me to confirm an issue I was having previously: #778

@elgalu elgalu added cla: yes and removed cla: no labels May 6, 2014
@KasMA1990
Copy link

IE11 is probably a bad idea for now as there are some issues with it and Selenium, but the ball is in Microsoft's court at the moment.
https://code.google.com/p/selenium/wiki/InternetExplorerDriver#IE_11_Support

@elgalu
Copy link
Contributor Author

elgalu commented May 6, 2014

The only npm test failing locally on IE11 is the one related to getCurrentUrl() so either fixing that issue or skipping it for IE, as we already do on our test suites, should allow to have it on the default test stack IMHO
UPDATE:
Changing from getCurrentUrl() to getLocationAbsUrl() should be enough on IE.

@elgalu
Copy link
Contributor Author

elgalu commented May 13, 2014

@juliemr
Copy link
Member

juliemr commented May 17, 2014

Agreed, we should be testing on it. I have worries that it will be flaky (as @KasMA1990 mentions), but it's better to know about failures. I'm concerned about the timeout-death though - asking Travis to re-run now.

@juliemr juliemr self-assigned this May 17, 2014
@elgalu
Copy link
Contributor Author

elgalu commented May 17, 2014

Yes, i'm not sure why it timed out on Sauce Labs because locally worked fine except for the getCurrentUrl() known IE bug.
This is the case where travis_retry may become handy but i see your point on waiting 30mins there, it is an unfortunate long delay :(

@elgalu
Copy link
Contributor Author

elgalu commented May 17, 2014

Oh i see the failure is similar again. I'll try to investigate a bit more, until there merging this one is probably not a good idea right now.

@elgalu elgalu closed this May 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants