This repository was archived by the owner on Sep 5, 2024. It is now read-only.
update(dialog): remove .md-actions deprecation #9637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes the `.md-actions` deprecation from pre- v1.0.0 * Simplifies the method to search for a close button Closes angular#9633
| @@ -80,7 +80,7 @@ md-dialog { | |||
| } | |||
| } | |||
|
|
|||
| .md-actions, md-dialog-actions { | |||
There was a problem hiding this comment.
we should leave the style classes for deprecated support (while we removing the warnings).
Otherwise this is a breaking change.
There was a problem hiding this comment.
We had them since pre v1.0.0 that's why I intentionally removed them for now. The target is to remove the deprecation completely (two major versions~)
ThomasBurleson
added
in progress
ThomasBurleson
added
needs: presubmit
and removed
in progress
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.md-actionsdeprecation from pre- v1.0.0Closes #9633