This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(panel): allow passing in a function to the offset methods #9615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErinCoughlan - ping for review. |
ErinCoughlan
approved these changes
Sep 15, 2016
| @@ -2003,7 +2005,7 @@ MdPanelPosition.prototype._validateXPosition = function(xPosition) { | |||
| /** | |||
| * Sets the value of the offset in the x-direction. This will add to any | |||
| * previously set offsets. | |||
| * @param {string} offsetX | |||
| * @param {string|Function(MdPanelPosition): string} offsetX | |||
There was a problem hiding this comment.
nit: Function -> function
ThomasBurleson
added
needs: presubmit
and removed
needs: review
* Allows for a function to be passed to the `withOffsetX` and `withOffsetY` methods which will help when trying to determine the offset dynamically. * Switches to assigning the offset before the position, in order to avoid tiny jumps in the UI on slower browsers. Fixes angular#9608.
crisbeto
force-pushed
the
9608/panel-offset-function
branch
from
55c6a74 to
480b00d
Compare
3 tasks
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
…ar#9615) * Allows for a function to be passed to the `withOffsetX` and `withOffsetY` methods which will help when trying to determine the offset dynamically. * Switches to assigning the offset before the position, in order to avoid tiny jumps in the UI on slower browsers. Fixes angular#9608.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withOffsetXandwithOffsetYmethods which will help when trying to determine the offset dynamically.Fixes #9608.