This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(menu): focus first non disabled item #9228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add some tests for this? It looks like we already have some autofocus-specific ones. https://github.com/angular/material/blob/master/src/components/menu/menu.spec.js#L155 |
clshortfuse
added
the
needs: unit tests
|
@topherfangio - please pair with Carlos for unit tests. |
ThomasBurleson
added
the
in progress
clshortfuse
force-pushed
the
menu-focusFirstEnabled
branch
3 times, most recently
from
d640c60 to
d2d02d3
Compare
clshortfuse
added
needs: review
|
@topherfangio please review :) |
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes angular#9165
clshortfuse
force-pushed
the
menu-focusFirstEnabled
branch
from
d2d02d3 to
f496ff5
Compare
topherfangio
added
needs: presubmit
and removed
needs: review
|
Manually tested and checked code. LGTM 👍 |
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes angular#9165
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate through menu items until it finds a non disabled item
Previously, menu would attempt to focus first item. If the item
was disabled, no attempts were made to seek another focusable item.
Fixes #9165