This repository was archived by the owner on Sep 5, 2024. It is now read-only.
md-menu does not close with Esc key when first menu-item is disabled #9165
Comments
siddhantpp
changed the title
|
It's likely due to the lack of a as seen properly implemented here: https://github.com/angular/material/blob/master/src/components/menu/js/menuController.js#L105 It also explains why you can hover over Enabled and then press escape after disabling the first item. |
clshortfuse
added a commit
to clshortfuse/material
that referenced
this issue
Aug 3, 2016
Iterate through menu items until it finds a non disabled item Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. Fixes angular#9165
clshortfuse
added
the
has: Pull Request
clshortfuse
added a commit
to clshortfuse/material
that referenced
this issue
Sep 11, 2016
Iterate through menu items until it finds a non disabled item Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. Fixes angular#9165
clshortfuse
added a commit
to clshortfuse/material
that referenced
this issue
Sep 11, 2016
Iterate through menu items until it finds a non disabled item Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. Fixes angular#9165
clshortfuse
added a commit
to clshortfuse/material
that referenced
this issue
Sep 11, 2016
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes angular#9165
clshortfuse
added a commit
to clshortfuse/material
that referenced
this issue
Sep 11, 2016
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes angular#9165
jelbourn
pushed a commit
that referenced
this issue
Sep 21, 2016
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes #9165
Frank3K
pushed a commit
to Frank3K/material
that referenced
this issue
Oct 8, 2016
Previously, menu would attempt to focus first item. If the item was disabled, no attempts were made to seek another focusable item. * Iterate through menu items until it finds a non-disabled item * Add more menu items to autofocus spec tests Fixes angular#9165
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Actual Behavior:
What is the issue? *When the first item in a md-menu is disabled, it refuses to close on pressing EscWhat is the expected behavior?md-Menu should close on pressing Esc regardless of whether the first item is disabled or not.CodePen (or steps to reproduce the issue): * CodePen link provided.
CodePen Demo which shows your issue:http://codepen.io/siddhantpp/pen/AXdGxmDetails:This CodePen demonstrates the issue. Click on Enable / Disable to test accordingly.Angular Versions: *
Angular Version:1.5.5Angular Material Version:1.0.9Additional Information:
Browser Type: *Google ChromeBrowser Version: *51.0.2704.106 m (64-bit)OS: *Windows 7Stack Traces:NoneShortcut to create a new CodePen Demo.
Note:
*indicates required information. Without this information, your issue may be auto-closed.The text was updated successfully, but these errors were encountered: