This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): only fill minimum required height. #9045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The list currently always expects the list items inner content to have a height of `100%`. In some specific browser cases the inner content, will calculate the `100%` in relative to the top element. Which causes the list items to be as big as the browsers screen height. * The inner content, should only have a min-height, which is the same as the defined height on the `md-list-item` item. Just inheriting the min-height will automatically use the correct value. Fixes angular#8956.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100%.In some specific browser cases the inner content, will calculate the
100%in relative to the top element.Which causes the list items to be as big as the browsers screen height.
md-list-itemitem.Just inheriting the min-height will automatically use the correct value.
Fixes #8956.