This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): apply foreground color and automatically detect theme #8723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply the missing foreground color on the md-dialog element * Automatically detect the theme from the `targetEvent` property. - Developers are still able to overwrite the theme (as before) - Theme will fallback to the default theme (as before) - If `targetEvent` is specified, it will use the `mdTheme` controller to lookup for a changed theme Fixes angular#8719.
|
@ErinCoughlan - can you review and test ? |
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetEventproperty.targetEventis specified, it will use themdThemecontroller to lookup for a changed themeFixes #8719.