Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Added mdPreventRefocus in sideNav #8179

Closed
wants to merge 2 commits into from
Closed

Conversation

jaxoncreed
Copy link

The code here

if ( !scope.isOpen ) {
refocuses on the element that opened the sidenav. This functionality isn't desirable in every context (for example I have an element with a md-tooltip that opens a sidenav. When the sidenav is closed, the tooltip with show up because the opener has been focused on)

Now adding md-prevent-refocus="true" will prevent this behaviour.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jaxoncreed
Copy link
Author

I've signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@devversion
Copy link
Member

@jaxoncreed Thanks for the contribution - I will close this PR, because a more elegant solution is already pending. See #7965

@devversion devversion closed this Apr 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants