Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

There was a minor RegExp change when moving the sanitize() function from md-autocomplete to $mdUtil. This caused a regression where md-autocomplete would throw an exception when ( was typed into the input.

Issue Number:
Fixes #11908

What is the new behavior?

No more exception. Sanitize RegExp updated. Tests fixed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar self-assigned this May 15, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label May 15, 2020
@Splaktar Splaktar requested a review from mmalerba May 15, 2020 01:59
@Splaktar Splaktar added this to the 1.1.23 milestone May 15, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug pr: merge ready This PR is ready for a caretaker to review labels May 15, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label May 15, 2020
@Splaktar Splaktar merged commit bc71d0b into master May 15, 2020
@Splaktar Splaktar deleted the autocomplete-regex-exception branch May 15, 2020 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete: SyntaxError: Invalid regular expression when typing (
3 participants