Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(tabs): exception when no selection and header clicked #11520

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Setting md-selected to -1 causes a click on the header to throw an exception.

Issue Number:
Fixes #10042

What is the new behavior?

No exception.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 21, 2018
@Splaktar Splaktar self-assigned this Nov 21, 2018
@Splaktar Splaktar added type: bug P4: minor Minor issues. May not be fixed without community contributions. labels Nov 21, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Nov 21, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Nov 21, 2018
@Splaktar Splaktar assigned jelbourn and mmalerba and unassigned jelbourn Dec 20, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@mmalerba mmalerba merged commit 9c079aa into master Jan 7, 2019
@Splaktar Splaktar deleted the tabsNoSelectionException branch January 7, 2019 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabs: an error message is shown when no tabs are selected
4 participants