Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(mdThemingProvider): add missing documentation #11209

Merged
merged 1 commit into from
Apr 6, 2018
Merged

docs(mdThemingProvider): add missing documentation #11209

merged 1 commit into from
Apr 6, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Apr 5, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The APIs were covered some in the guide, but not in the service docs.
The docs were inconsistent in descriptions and formatting.

Issue Number:
Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.

What is the new behavior?

Missing documentation exists.
Update existing docs for consistency.

Does this PR introduce a breaking change?

[ ] Yes
[d] No

Other information

N/A

@Splaktar
docs(mdThemingProvider): add missing documentation
521b536 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.
@Splaktar Splaktar added type: docs ui: theme P3: important Important issues that really should be fixed when possible. labels Apr 5, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 5, 2018
@Splaktar Splaktar requested a review from EladBezalel April 5, 2018 06:31
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 5, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Apr 5, 2018
jelbourn
jelbourn approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 40e1f2d into master Apr 6, 2018
@Splaktar Splaktar deleted the improveMdThemingProviderDocs branch April 6, 2018 06:45
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@Splaktar @chmelevskij
docs(mdThemingProvider): add missing documentation (angular#11209)
1747f01 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to angular#2965. Relates to angular#9475. Relates to angular#9476.
Relates to angular#10458. Relates to angular#10458.
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
docs(mdThemingProvider): add missing documentation (#11209)
649d6aa 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@EladBezalel EladBezalel Awaiting requested review from EladBezalel

Assignees

@jelbourn jelbourn

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: docs ui: theme
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@Splaktar @jelbourn @googlebot