Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

better styling for deprecated api items #384

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

devversion
Copy link
Member

  • Adds a dotted underline to the Deprecated markers. Those can be hovered to see more information about the deprecation / deletion.
  • Fixes that the deprecation markers are too big and are not looking good in the API table
  • Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good.

image

References angular/components#9648

@devversion devversion changed the title better styling for deprecated api itms better styling for deprecated api items Feb 6, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion.
* Fixes that the deprecation markers are too big and are not looking good in the API table
* Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good.

References angular/components#9648
@devversion devversion force-pushed the better-styling-deprecated branch from c4c07cf to 44168e8 Compare February 6, 2018 16:53
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit c2443fc into angular:master Feb 9, 2018
@devversion devversion deleted the better-styling-deprecated branch February 9, 2018 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants