This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat(sw): adds ngsw config #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
reviewed
Dec 12, 2017
src/app/app-module.ts
Outdated
| @@ -33,6 +33,8 @@ import { | |||
| CanActivateComponentSidenav | |||
| } from './pages/component-sidenav/component-sidenav-can-load-guard'; | |||
| import {HttpClientModule} from '@angular/common/http'; | |||
| import { ServiceWorkerModule } from '@angular/service-worker'; | |||
| import { environment } from '../environments/environment'; | |||
|
Just finished testing the service worker, looks like it works =) |
|
@amcdnl just needs rebase now to be ready to go in |
# Conflicts: # ngsw-manifest.json
|
@jelbourn - good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the Angular CLI 1.6 and Angular Service Worker config to setup service workers for the docs site. Cache busting seems to work based on hashing strategies the cli generates.
Important note for when testing: SWs do not work w/
ng-serve, see: https://angular.io/guide/service-worker-getstart#serving-with-http-server