This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(fxFlex): fix non-wrapping behavior and default fxFlex value #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
force-pushed
the
adam/fix-issue-481
branch
2 times, most recently
from
78db2b1 to
a46590c
Compare
|
Note: confirmed issue with IE11 by removing the hack. Will consult Flexbugs and try to come up with an alternative that meets all requirements. |
CaerusKaru
force-pushed
the
adam/fix-issue-481
branch
2 times, most recently
from
6dad8d3 to
0d1c306
Compare
|
Fixed the default value and officially unblocked |
This was referenced Mar 17, 2018
CaerusKaru
force-pushed
the
adam/fix-issue-481
branch
from
0d1c306 to
2539adb
Compare
|
rebase this one also plz @CaerusKaru |
* Set the non-wrapping behavior for fxFlex to be 100% instead of the width/height value * Set the default value for fxFlex to auto instead of 1e-9px
CaerusKaru
force-pushed
the
adam/fix-issue-481
branch
from
2539adb to
a0a4580
Compare
|
@ThomasBurleson done |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the width/height value
row instead of 1e-9px
Fixes #666
Fixes #481
Fixes #544
Fixes #338
Fixes #314