Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

bug(fxFlex): flex basis should only be set to width value when wrapping #666

Closed
CaerusKaru opened this issue Mar 15, 2018 · 1 comment · Fixed by #669
Closed

bug(fxFlex): flex basis should only be set to width value when wrapping #666

CaerusKaru opened this issue Mar 15, 2018 · 1 comment · Fixed by #669
Assignees
Labels
bug flexbox has pr A PR has been created to address this issue

Comments

@CaerusKaru
Copy link
Member

Currently the flex-basis is set to the value of the width when present as a fix for wrapping in older versions of Safari. However, this throws off ordinary flex values when not wrapping (and is not needed when not wrapping).

Need a partial revert of the recent PR to fix this, with a patch that detects wrapping

@CaerusKaru CaerusKaru added this to the v6.0.0-beta.14 milestone Mar 15, 2018
@CaerusKaru CaerusKaru self-assigned this Mar 15, 2018
@CaerusKaru CaerusKaru added has pr A PR has been created to address this issue and removed in-progress labels Mar 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug flexbox has pr A PR has been created to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant