fix(@schematics/angular): Allow for scoped library names

[Brocco]

fixes angular/angular-cli#10172

[hansl]

What if the name passed on the command line is a/b/c? Is it going to create c in /projects/a/b?

[hansl]

The removal of @ and replacing / with - looks good, I just want to make sure we still allow for other cases.

[filipesilva]

I think it would be good to keep the /. So @scoped/lib would go into projects/scoped/lib, kinda like we have things in the CLI and DevKit repos. No opinion on the @ myself.

[Brocco]

@about-code in my experience having @ in paths messes up autocompleting paths in consoles (both Mac & Windows) which is why I removed it as part of the directory structure.

[hansl]

replace(/^@/, '')

[hansl]

Question; do we check that I cannot enter any strings somewhere? Do we have a pattern in the schema?

[Brocco]

@hansl I updated the logic to validate the project name... but not via a schema pattern in order to provide more verbose error messages.

[about-code]

I am not yet sure whether it's preferable to strip the @ even though I see the advantages on the console. I certainly don't know enough about the full library implementation in the CLI to make any concrete suggestions. But let me explain some thoughts I had, e.g. about how it might affect webpack module resolution and potential benefits for lazy loaded modules:

Assume an Angular app wants to lazy load an NgModule from a library in the projects folder. If Webpack were configured to resolve import paths from the projects folder like so:

module: { 
     resolve: ["./projects", "./node_modules"]
}

then it might (not tested in CLI context) become possible to compile angular apps which load an NgModule from a library with an absolute path beginning with the package name maybe like so:

// Assumption: AoT-Compiler translates the path to a dynamic webpack import()
loadChildren: '@foo/bar/src/lib/bar.module#BarModule' 

Webpack were able to resolve import("@foo/bar") by not just looking into node_modules but also in projects which may avoid the need for npm linking, or copying things into node_modules in some situations. I am not sure how CLI projects are configured in this regard but I think it could have some benefits to take npm module resolution algorithms into account.

[filipesilva]

@about-code we add TS path configuration pointing the to built library artifacts. Our webpack plugin adds the TS paths to the module resolution logic of webpack. This way the folder name proper does not matter.

[about-code]

@filipesilva Thank you very much for your response and for taking away my concerns. Now I am gonna be quiet on this. 😃

[hansl]

${JSON.stringify(projectName)}

[rodchenkov]

Hi All
Just found that in tsconfig.json path name for scoped library is without scope name.
I think we need to solve this.

[filipesilva]

@rodchenkov I have a fix incoming in #895