fix(@schematics/angular): Allow for scoped library names

fixes angular/angular-cli#10172

Author: Brocco

packages/schematics/angular/library/files/__projectRoot__/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "<%= dasherize(name) %>",
+  "name": "<%= packageName %>",
   "version": "0.0.1",
   "peerDependencies": {
     "@angular/common": "^6.0.0-rc.0 || ^6.0.0",

packages/schematics/angular/library/index.ts

@@ -171,7 +171,11 @@ export default function (options: LibraryOptions): Rule {
     if (!options.name) {
       throw new SchematicsException(`Invalid options, "name" is required.`);
     }
-    const name = options.name;
+    // If scoped project (i.e. "@foo/bar"), convert projectDir to "foo-bar".
+    const packageName = options.name;
+    options.name = /@[\S]*\/[\S]*/.test(options.name)
+      ? options.name.replace(/^@/, '').replace(/\//, '-')
+      : options.name;
 
     const workspace = getWorkspace(host);
     const newProjectRoot = workspace.newProjectRoot;
@@ -182,6 +186,7 @@ export default function (options: LibraryOptions): Rule {
       template({
         ...strings,
         ...options,
+        packageName,
         projectRoot,
       }),
       // TODO: Moving inside `branchAndMerge` should work but is bugged right now.
@@ -193,27 +198,27 @@ export default function (options: LibraryOptions): Rule {
       branchAndMerge(mergeWith(templateSource)),
       addAppToWorkspaceFile(options, workspace),
       options.skipPackageJson ? noop() : addDependenciesToPackageJson(),
-      options.skipTsConfig ? noop() : updateTsConfig(name),
+      options.skipTsConfig ? noop() : updateTsConfig(options.name),
       schematic('module', {
-        name: name,
+        name: options.name,
         commonModule: false,
         flat: true,
         path: sourceDir,
         spec: false,
       }),
       schematic('component', {
-        name: name,
+        name: options.name,
         inlineStyle: true,
         inlineTemplate: true,
         flat: true,
         path: sourceDir,
         export: true,
       }),
       schematic('service', {
-        name: name,
+        name: options.name,
         flat: true,
         path: sourceDir,
-        module: `${name}.module.ts`,
+        module: `${options.name}.module.ts`,
       }),
     ])(host, context);
   };

packages/schematics/angular/library/index_spec.ts

@@ -16,7 +16,7 @@ function getJsonFileContent(tree: UnitTestTree, path: string) {
   return JSON.parse(tree.readContent(path));
 }
 
-describe('Library Schematic', () => {
+fdescribe('Library Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/ng_packagr',
     path.join(__dirname, '../collection.json'),
@@ -166,4 +166,16 @@ describe('Library Schematic', () => {
       expect(tsConfigJson.compilerOptions.paths).toBeUndefined();
     });
   });
+
+  it(`should support creating scoped libraries`, () => {
+    const scopedName = '@scope/lib';
+    const options = { ...defaultOptions, name: scopedName };
+    const tree = schematicRunner.runSchematic('library', options, workspaceTree);
+
+    const pkgJsonPath = '/projects/scope-lib/package.json';
+    expect(tree.files).toContain(pkgJsonPath);
+
+    const pkgJson = JSON.parse(tree.readContent(pkgJsonPath));
+    expect(pkgJson.name).toEqual(scopedName);
+  });
 });