-
Notifications
You must be signed in to change notification settings - Fork 155
feat(@schematics/angular): Add directive and component selector rules #644
Conversation
60c46d0
to
58121f6
Compare
@Brocco could you have a look please? Mike really is the authority on these things so I'd defer to him. |
Answers to your questions
Nice work thus far! |
58121f6
to
b87d7d1
Compare
@Brocco I made all the changes. Only the problem 1 persists and i don't really know what i can do. As soon as i add |
@chrste90 now that you mention it again, I think I ran into a similar problem in the library schematics... Having moved files with the same name should work, but is bugged and does not. The workaround is to have a template folder named When I did that I removed the |
b87d7d1
to
180944f
Compare
Thanks @filipesilva |
Also another thing (maybe it's a known problem):
|
542e93a
to
f33405b
Compare
f33405b
to
5df6138
Compare
@chrste90 yeah that test is flaky on some environments. Not too sure why myself, but it is known. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Here is the initial implementation and fix of #570
Some questions:
schematics/angular/application/files/root/tslint.json
, the workspace tslint file is not copied when i runng new App
, only the extending tslint exists in the created application. Is it not possible to create two files with the same name in different directories or am i missing something?lib
for now. Should i add a prefix property and use it?CC @filipesilva