This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): Add skip git option to prevent creating git… #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
suggested changes
Sep 25, 2017
| @@ -94,6 +94,7 @@ export default function (options: ApplicationOptions): Rule { | |||
| mergeWith( | |||
| apply(url('./files'), [ | |||
| options.minimal ? filter(minimalPathFilter) : noop(), | |||
| options.skipGit ? filter(path => !path.endsWith('gitignore')) : noop(), | |||
There was a problem hiding this comment.
Could you check the whole path? !path.endsWith('/__dot__gitignore')?
There was a problem hiding this comment.
fixed this (plus linting issue in generated schema file)
| @@ -25,11 +25,11 @@ export interface Schema { | |||
| /** | |||
| * Specifies the view encapsulation strategy. | |||
| */ | |||
| viewEncapsulation?: ('Emulated' | 'Native' | 'None'); | |||
| viewEncapsulation?: ("Emulated" | "Native" | "None"); | |||
There was a problem hiding this comment.
Unfortunately you have to do a devkit-admin lint --fix run after generating the .d.ts. This won't pass linting.
hansl
approved these changes
Sep 25, 2017
Brocco
added a commit
to Brocco/angular-cli
that referenced
this pull request
Sep 28, 2017
Brocco
added a commit
to Brocco/angular-cli
that referenced
this pull request
Sep 28, 2017
Brocco
added a commit
to Brocco/angular-cli
that referenced
this pull request
Sep 28, 2017
hansl
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 28, 2017
filipesilva
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 28, 2017
filipesilva
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 28, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ignore file
fixes angular/angular-cli#7686