Skip to content

build: fix chrome headless not starting #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2018
Merged

build: fix chrome headless not starting #9418

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7195714
build: fix chrome headless not starting
devversion Jan 16, 2018
a600c38
Add comment for node version
devversion Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
language: node_js
sudo: false
dist: trusty

# Temporary set sudo to required, because in normal container-based Travis jobs, the Chrome
# binaries seem to be owned by root, and therefore can't be accessed by Karma. To workaround
# the issue we temporary grant the CI sudo permissions.
# https://github.com/travis-ci/travis-ci/issues/8836#issuecomment-356362524.
sudo: required

node_js:
- '8'
- '8.9.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that explains why this specific version of node is used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this makes sense. It's the latest LTS version of NodeJS, and this comment would get outdated from time to time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why not leave it as 8? My understanding is that Travis should use the latest version of 8.x.
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I just saw that angular/angular is also more explicit with it, and that way I thought we can be more carefully about auto-upgrades of the node version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might do it to make sure every build is consistent, which would be a good reason. Still worth commenting, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I will add a comment that explains that we won't to be explicit about this version as well for job consistency.


addons:
jwt:
Expand Down