Skip to content

revert #8654 #8865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2017
Merged

revert #8654 #8865

merged 1 commit into from
Dec 7, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Dec 7, 2017

No description provided.

@mmalerba mmalerba requested a review from kara as a code owner December 7, 2017 17:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 7, 2017
tinayuangao
tinayuangao approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 0c39219 into angular:master Dec 7, 2017
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 8, 2017
@mmalerba mmalerba deleted the revert-8654 branch July 31, 2018 21:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

@kara kara Awaiting requested review from kara

1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @tinayuangao @crisbeto @googlebot