feat(tree): add tree demo page #8749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
pr: needs review
and removed
cla: yes
benb7760
reviewed
Nov 30, 2017
|
|
||
| getChildren = (node: JsonNode) => { return ofObservable(node.children); } | ||
|
|
||
| hasChild = (_: number, _nodeData: JsonFlatNode) => { return _nodeData.expandable; } |
There was a problem hiding this comment.
@tinayuangao I noticed this a week or so ago while trialling the tree; users have to define two functions that achieve the exact same result but with different signatures; isExpandable, used by the when, and hasChild, used by the TreeControl. Would it be sensible to change this?
jelbourn
reviewed
Dec 8, 2017
| /** Tree flattener to transfrom JsonNode to JsonFlatNode */ | ||
| export class TreeFlattener { | ||
|
|
||
| static flattenNodes( structuredData: JsonNode[]): JsonFlatNode[] { |
| structuredData.forEach((node) => { | ||
| this._flattenNode(node, 0, resultNodes, []); | ||
| }); | ||
| return resultNodes; |
There was a problem hiding this comment.
return structuredData.map(node => this._flattenNode(node, 0, resultNodes, []));| /** Tree flattener to transfrom JsonNode to JsonFlatNode */ | ||
| export class TreeFlattener { | ||
|
|
||
| static flattenNodes( structuredData: JsonNode[]): JsonFlatNode[] { |
There was a problem hiding this comment.
Would it make sense to just have module-level functions instead of static methods?
src/demo-app/tree/tree-demo.html
Outdated
| <mat-card> | ||
| <mat-card-header>Flattened tree</mat-card-header> | ||
|
|
||
| <mat-tree [dataSource]="dataSource" [treeControl]="treeControl">--> |
|
|
||
| constructor(database: JsonDatabase) { | ||
| // For flat tree | ||
| this.treeControl = new FlatTreeControl<JsonFlatNode>(this.getLevel, this.isExpandable); |
There was a problem hiding this comment.
Would it make sense to use a more real-world example, such as collection of directories?
tinayuangao
force-pushed
the
mat-tree-demo
branch
from
7b0ae83 to
d93eef7
Compare
googlebot
added
the
cla: yes
|
Comments addressed. Please take a look. Thanks! |
jelbourn
added
pr: lgtm
action: merge
tinayuangao
added a commit
that referenced
this pull request
Dec 13, 2017
tinayuangao
added a commit
that referenced
this pull request
Dec 14, 2017
tinayuangao
added a commit
that referenced
this pull request
Dec 15, 2017
tinayuangao
added a commit
to tinayuangao/material2
that referenced
this pull request
Dec 15, 2017
tinayuangao
added a commit
that referenced
this pull request
Dec 19, 2017
tinayuangao
added a commit
that referenced
this pull request
Jan 4, 2018
tinayuangao
added a commit
that referenced
this pull request
Jan 10, 2018
tinayuangao
added a commit
that referenced
this pull request
Jan 23, 2018
tinayuangao
added a commit
that referenced
this pull request
Feb 5, 2018
tinayuangao
added a commit
that referenced
this pull request
Feb 9, 2018
jelbourn
pushed a commit
that referenced
this pull request
Feb 12, 2018
tinayuangao
added a commit
that referenced
this pull request
Feb 13, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.