Skip to content

feat(menu-item): allow disabling ripples #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2017
Merged

feat(menu-item): allow disabling ripples #8388

merged 1 commit into from
Nov 20, 2017

Conversation

devversion
Copy link
Member

  • Allows disabling ripples for specific menu items.

Closes #8261

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2017
crisbeto
crisbeto approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 12, 2017
jelbourn
jelbourn approved these changes Nov 18, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion
feat(menu-item): allow disabling ripples
69ca195 
* Allows disabling ripples for specific menu items.

Closes angular#8261
@devversion devversion force-pushed the feat/menu-item-disable-ripple branch from 6780106 to 69ca195 Compare November 19, 2017 09:10
@jelbourn jelbourn merged commit ce23395 into angular:master Nov 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

Assignees

@crisbeto crisbeto

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow disableRipple on mat-menu-item buttons

5 participants

@devversion @jelbourn @crisbeto @googlebot @andrewseguin