Skip to content

docs(ripple): update documentation #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

devversion
Copy link
Member

  • Improves the documentation of the matRipple attribute directive.

References #7543.

* Improves the documentation of the `matRipple` attribute directive.

References angular#7543.
@devversion devversion added docs This issue is related to documentation pr: needs review labels Oct 21, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2017
```

By default, a ripple is activated when the host element of the `matRipple` directive receives
mouse or touch events. Once element is being pressed, a ripple starts fading in from the point
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once element is being pressed..." ->
"Upon being pressed, a ripple will begin fading in from the point of contact, radiating to cover the host element"

mouse or touch events. Once element is being pressed, a ripple starts fading in from the point
of contact and expands circularly to cover the full host element.

As long as the user does not release the element, the ripples will not fade out. Releasing the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Each ripple will fade out only upon release of the mouse or touch"


### Ripple trigger

As mentioned previously, by default ripples will fade in on interaction with the directive's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit "As mentioned previously"

As mentioned previously, by default ripples will fade in on interaction with the directive's
host element.

In some situations, developers may want to show ripples on interaction with *another* element,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine with previous paragraph

As mentioned previously, by default ripples will fade in on interaction with the directive's
host element.

In some situations, developers may want to show ripples on interaction with *another* element,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"another" -> "some other"

In some situations, developers may want to show ripples on interaction with *another* element,
but still want to have the ripples placed in another location.

This can be done by specifying the `matRippleTrigger` option that expects a reference to a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine with previous paragraph

In some situations, developers may want to show ripples on interaction with *another* element,
but still want to have the ripples placed in another location.

This can be done by specifying the `matRippleTrigger` option that expects a reference to a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an HTMLElement"

})
```

All currently available global options are shown here:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just be captured by API docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interfaces are not being displayed in the docs yet. We might be able to change the interface to a class, but I'd rather would like to setup Dgeni to show interfaces (in a follow-up)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one last thing I noticed. add merge-ready when ready

@@ -0,0 +1,95 @@
# matRipple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit the top #matRipple header (it is added by the docs site)

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Oct 26, 2017
@mmalerba mmalerba merged commit c707007 into angular:master Oct 27, 2017
@devversion devversion deleted the docs/ripple-documentation branch January 18, 2018 21:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants