Skip to content

Raise ripple from core to src/lib #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 7 tasks
jelbourn opened this issue Oct 5, 2017 · 2 comments
Closed
3 of 7 tasks

Raise ripple from core to src/lib #7543

jelbourn opened this issue Oct 5, 2017 · 2 comments
Assignees
@devversion
Labels
docs This issue is related to documentation feature This issue represents a new feature or feature request rather than a bug or bug fix in progress This issue is currently in progress

Comments

@jelbourn
Copy link
Member

jelbourn commented Oct 5, 2017 •
edited by devversion
Loading

  • Move ripple code from src/lib/core to src/lib directly
  • Add tsconfigs
  • Add ripple.md overview
  • Rework public API for easier-use.
  • Generate material-ripple.html for docs output.
  • Add live examples
  • Add ripple to docs-items on material.angular.io
@jelbourn jelbourn added docs This issue is related to documentation feature This issue represents a new feature or feature request rather than a bug or bug fix labels Oct 5, 2017
@devversion devversion self-assigned this Oct 5, 2017
devversion added a commit to devversion/material2 that referenced this issue Oct 21, 2017
@devversion
docs(ripple): update documentation
3652382 
* Improves the documentation of the `matRipple` attribute directive.

References angular#7543.
@devversion devversion mentioned this issue Oct 21, 2017
Merged
mmalerba pushed a commit that referenced this issue Oct 27, 2017
@devversion @mmalerba
docs(ripple): update documentation (#7941)
c707007 
* docs(ripple): update documentation

* Improves the documentation of the `matRipple` attribute directive.

References #7543.

* Address feedback

* Omit matRipple header
@devversion devversion mentioned this issue Dec 30, 2017
Merged
@crisbeto crisbeto mentioned this issue Apr 15, 2018
Closed
@devversion devversion mentioned this issue Jun 24, 2018
Merged
devversion added a commit to devversion/material2 that referenced this issue Jul 4, 2018
@devversion
chore: add example for ripple
4381a96 
* Moves the ripple demo into a more bare-bone example that can shown in the docs at some point.

References angular#7543
@devversion devversion mentioned this issue Jul 4, 2018
Merged
devversion added a commit to devversion/material2 that referenced this issue Jul 9, 2018
@devversion
chore: add example for ripple
64cd49c 
* Moves the ripple demo into a more bare-bone example that can shown in the docs at some point.

References angular#7543
@devversion
Copy link
Member

The ripple directive is still part of core/, but is documented now. It also includes live examples.

We didn't move it into a separate entry-point because the <mat-option> directive within core/ also depends on the ripples.

So, that would mean that we either need to extract MatOption into a separate module, or the @angular/material/core would depend on @angular/material/ripple. This feels a bit odd.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@mmalerba mmalerba added the in progress This issue is currently in progress label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
docs This issue is related to documentation feature This issue represents a new feature or feature request rather than a bug or bug fix in progress This issue is currently in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jelbourn @devversion @mmalerba