feat(icon): add e2e icon tests #794
Merged
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
e2e/components/icon/icon.e2e.ts
Outdated
| testIcon = element(by.id('test-icon')); | ||
| }); | ||
|
|
||
| it('aria-label should be correct', () => { |
There was a problem hiding this comment.
Tests should be of the form
it('should set the aria-label from the ligature name', ...
|
LGTM other than the names of the tests |
|
@jelbourn Ok, I changed the test names. |
|
@jesselpalmer minor lint error |
|
@jelbourn ok, blank line ending added, though strangely they don't appear on GitHub. |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes basic tests for icon and removes unnecessary code from
e2e-app.tsande2e-app.html, similarly found in PR #650.Closes #560.
R: @jelbourn