Skip to content

fix(cdk): prevent attribute renaming in observe-content.ts for closure compiler ADVANCED optimizations #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Oct 18, 2017

I got the following error after building my new project with Angular Material 2.0.0-beta.12, Angular 5.0.0-rc.0 & the latest closure compiler.

    at j.(anonymous function).XMLHttpRequest.t.responseBlob.e.function.o.(anonymous function).j.(anonymous function).(anonymous function) [as observe] (http://localhost:8888/assets/js/zone.min.js:1:1959)
    at $ObserveContent$$module$node_modules$$angular$cdk$esm2015$observers$$.$$ObserveContent$$module$node_modules$$angular$cdk$esm2015$observers$$$$$ngAfterContentInit$$ [as $ngAfterContentInit$] (http://localhost:8888/assets/js/browser.js:7727:27)
    at $callProviderLifecycles$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:3545:269)
    at $callLifecycleHooksChildrenFirst$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:3534:87)
    at $checkAndUpdateView$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:3845:3)
    at $callViewAction$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:4208:67)
    at $execComponentViewsAction$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:4178:49)
    at $checkAndUpdateView$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:3847:3)
    at $callViewAction$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:4208:67)
    at $execComponentViewsAction$$module$node_modules$$angular$core$esm2015$core$$ (http://localhost:8888/assets/js/browser.js:4178:49)

Tracked it down to attributes in an observe(...) call in observer-content.ts being renamed during advanced optimizations.

This PR fixes the issue.

… optimizations... these attributes should not be renamed
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 18, 2017
@gregmagolan gregmagolan changed the title Fix in CDK observers observe-content.js for closure compiler ADVANCED optimizations... these attributes should not be renamed fix(cdk): prevent attribute renaming in observe-content.js for closure compiler ADVANCED optimizations Oct 18, 2017
@gregmagolan gregmagolan changed the title fix(cdk): prevent attribute renaming in observe-content.js for closure compiler ADVANCED optimizations fix(cdk): prevent attribute renaming in observe-content.ts for closure compiler ADVANCED optimizations Oct 18, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 20, 2017
@josephperrott josephperrott merged commit 8dfe470 into angular:master Nov 10, 2017
josephperrott added a commit that referenced this pull request Nov 10, 2017
…pilers advanced optimizations (#7894)"

This reverts commit 8dfe470.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants