fix(autocomplete): error when closing from a destroyed view #7365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
adamhazon
approved these changes
Oct 23, 2017
|
@crisbeto just needs rebase, add merge-ready when ready |
Fixes an error that was being thrown, because the autocomplete tries to run change detection on a destroyed view. Fixes angular#7315.
crisbeto
force-pushed
the
7315/autocomplete-close-error
branch
from
e3e77bc to
2cee7d7
Compare
crisbeto
added
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…7365) Fixes an error that was being thrown, because the autocomplete tries to run change detection on a destroyed view. Fixes angular#7315.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that was being thrown, because the autocomplete tries to run change detection on a destroyed view.
Fixes #7315.
Note: The repro case is somewhat convoluted and while I could reproduce the issue in the demo app, I had a hard time getting it to throw the error during unit tests. I added a comment instead since the logic is pretty straightforward.