Skip to content

fix(menu): multiple close events for a single close #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(menu): multiple close events for a single close #7037

merged 1 commit into from
Sep 29, 2017

Conversation

ppham27
Copy link
Contributor

@ppham27 ppham27 commented Sep 13, 2017

Don't emit a closed event when another event will be emitted. Previously, if one clicked on a menu item, one would get two events: undefined and click in that order. One would see similar behavior for keydown or clicking the backdrop. Unit tests were updated to prevent a regression.

Making a second pull request. See #7036.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 13, 2017
ppham27 referenced this pull request Sep 13, 2017
@mmalerba
Revert "fix(menu): multiple close events for a single close" (#7036)
dcfe515 
* Revert "feat(datepicker): Add Moment.js adapter (#6860)"

This reverts commit 9545427.

* Revert "fix(menu): multiple close events for a single close (#6961)"

This reverts commit 1cccd4b.
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 13, 2017
@mmalerba
Copy link
Contributor

caretaker note: previously saw unexpected screenshot diffs when merging this, make sure global presubmit is ok before merging

@ppham27 ppham27 force-pushed the mdMenu branch 2 times, most recently from 2051993 to 041e80a Compare September 24, 2017 18:58
@ppham27
fix(menu): multiple close events for a single close
f436e13 
Don't emit a closed event when another event will be emitted. Previously, if one clicked on a menu item, one would get two events: `undefined` and `click` in that order. One would see similar behavior for `keydown` or clicking the backdrop. Unit tests were updated to prevent a regression.
@andrewseguin andrewseguin merged commit 2dcb76c into angular:master Sep 29, 2017
@ppham27 ppham27 deleted the mdMenu branch October 2, 2017 00:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

@kara kara Awaiting requested review from kara

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppham27 @mmalerba @googlebot @andrewseguin