Skip to content

perf(sidenav): avoid recalculating the inline styles while sidenav is open #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2017
Merged

perf(sidenav): avoid recalculating the inline styles while sidenav is open #6189

merged 1 commit into from
Aug 2, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 1, 2017 •
edited by andrewseguin
Loading

  • Avoids recalculating the sidenav inline styles for every change detection cycle while the sidenav is open by doing it only when an animation starts.
  • Removes a few one-liner methods that were being used in one place.

Fixes #6205

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2017
mmalerba
mmalerba approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000 I hope I'm not the one that wrote this originally... but I probably am ><

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 1, 2017
@jelbourn
Copy link
Member

jelbourn commented Aug 1, 2017

Nah, it was totes Hans

@tinayuangao
Copy link
Contributor

@crisbeto Could you please rebase? Thanks!

@crisbeto crisbeto force-pushed the sidenav-recalc-styles branch from d6be6fa to 3f5ba45 Compare August 2, 2017 04:32
@crisbeto
Copy link
Member Author

crisbeto commented Aug 2, 2017

Rebased @tinayuangao.

@crisbeto
perf(sidenav): avoid recalculating the inline styles while sidenav is…
bd97dba 
… open

* Avoids recalculating the sidenav inline styles for every change detection cycle while the sidenav is open by doing it only when an animation starts.
* Removes a few one-liner methods that were being used in one place.
@crisbeto crisbeto force-pushed the sidenav-recalc-styles branch from 3f5ba45 to bd97dba Compare August 2, 2017 05:12
@tinayuangao tinayuangao merged commit 57a2f29 into angular:master Aug 2, 2017
@willshowell willshowell mentioned this pull request Aug 9, 2017
Closed
@dereekb dereekb mentioned this pull request Aug 30, 2017
Closed
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 16, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
8da8c0b 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
@crisbeto crisbeto mentioned this pull request Nov 16, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 17, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
1c685f4 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 17, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
8947aec 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 17, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
08fa7d0 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 28, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
61783b6 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 4, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
1436eee 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 4, 2017
@crisbeto
fix(drawer): allow for drawer container to auto-resize while open
ae04fcf 
Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before angular#6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes angular#6743.
mmalerba pushed a commit that referenced this pull request Dec 5, 2017
@crisbeto @mmalerba
fix(drawer): allow for drawer container to auto-resize while open (#8488
e7b412a 
)

Adds the `autosize` input that allows users to opt-in to drawers that auto-resize, similarly to the behavior before #6189. The behavior is off by default, because it's unnecessary for most use cases and can cause performance issues.

Fixes #6743.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidenav forces render each change detection
5 participants
@crisbeto @jelbourn @tinayuangao @mmalerba @googlebot