Skip to content

build: peer dependency for material-examples package #6165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 31, 2017

  • Adds peer dependencies for the CDK and Material to the examples package. This ensures that the API that is used in the examples is always compatible with the current installed version of the CDK or Material.

Note: This does not really affect the docs because the examples are just copied into the node_modules, but it's still good to have the peer dependencies specified.

* Adds peer dependencies for the CDK and Material to the examples package. This ensures that the API that is used in the examples is always compatible with the current installed version of the CDK or Material.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 31, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 31, 2017
@tinayuangao tinayuangao merged commit 2b59c96 into angular:master Jul 31, 2017
@devversion devversion deleted the build/peer-dep-examples branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants