Skip to content

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jun 1, 2016

Removes the three instances of circular deps and adds a CI check to prevent future regressions.

@jelbourn jelbourn added the in progress This issue is currently in progress label Jun 1, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2016
@jelbourn jelbourn changed the title [WIP] fix: remove circular deps fix: remove circular deps and add ci check Jun 1, 2016
@jelbourn jelbourn added pr: needs review and removed in progress This issue is currently in progress labels Jun 1, 2016
@jelbourn
Copy link
Member Author

jelbourn commented Jun 1, 2016

R: @hansl @kara
CC: @mprobst @vikerman

@kara
Copy link
Contributor

kara commented Jun 2, 2016

LGTM. We should eventually change our system-config.ts to have a main file configured at some point, so we don't have to do @angular2-material/core/core

@jelbourn jelbourn merged commit fda5617 into angular:master Jun 2, 2016
mcoffin added a commit to mcoffin/ng2-material that referenced this pull request Jul 6, 2016
@jelbourn jelbourn deleted the circular branch September 13, 2017 04:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants