Skip to content

docs(table): add missing table JsDoc #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jul 6, 2017

Also

  • Adds links to table overview/guide
  • Fixes missing package.json dep for our own build tools
  • Removes header from table examples that had a problematic background color for dark themes
  • Configure dgeni to output API docs for table and sort-header

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe labels Jul 6, 2017
@jelbourn jelbourn requested review from mmalerba and andrewseguin July 6, 2017 00:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2017
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker pr: lgtm and removed pr: needs review labels Jul 6, 2017
@jelbourn jelbourn force-pushed the table-docs-fixes branch from 641ec76 to 6954550 Compare July 6, 2017 01:25
@mmalerba mmalerba merged commit 8a74973 into angular:master Jul 6, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
@jelbourn jelbourn deleted the table-docs-fixes branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants