chore: screenshots task cleanup #5416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Attempt to make the screenshot task more readable and easier to understand. The screenshot task includes a lot of magic (due to the Firebase functions JWT solution) and we should try our best to make it as readable as possible.
devversion
force-pushed
the
chore/screenshot-task-cleanup
branch
from
1a9f55b to
001bf7f
Compare
jelbourn
approved these changes
Jul 11, 2017
| // This means that those types are really long and it's nearly impossible to write a function that | ||
| // doesn't exceed the maximum columns. Import the types from the namespace so they are shorter. | ||
| import Database = firebaseAdmin.database.Database; | ||
| import DataSnapshot = firebaseAdmin.database.DataSnapshot; |
There was a problem hiding this comment.
FirebaseDatabase and FirebaseDataSnapshot?
There was a problem hiding this comment.
Would work as well, but the main intention was to keep it as short as possible.
There was a problem hiding this comment.
I aim for explicitness first and brevity second.
There was a problem hiding this comment.
Hmm not sure. It should be pretty clear from the file name and from the comment as well.
There was a problem hiding this comment.
I don'r care that much for this one
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to make the screenshot task more readable and easier to understand. The screenshot task includes a lot of magic (due to the Firebase functions JWT solution) and we should try our best to make it as readable as possible.
Note: This also fixes that the screenshot results are uploaded outside of Gulp (causing gulp to continue with other tasks while this is running)