Skip to content

chore: move sanity checks to common module #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2017
Merged

chore: move sanity checks to common module #4987

merged 2 commits into from
Jun 8, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 6, 2017

Moves the sanity checks to the MdCommonModule.

Fixes #4979.

@crisbeto
chore: move sanity checks to common module
f4e6995 
Moves the sanity checks to the `MdCommonModule`.

Fixes angular#4979.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 6, 2017
jelbourn
jelbourn approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 6, 2017
@andrewseguin
Copy link
Contributor

Looks like MATERIAL_SANITY_CHECKS is no longer provided by @angular/material anymore since it isn't included in any index.ts. Previously it was caught by export * from './compatibility/compatibility'; in core.ts

@andrewseguin andrewseguin removed the action: merge The PR is ready for merge by the caretaker label Jun 8, 2017
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Jun 8, 2017

Re-exported the provider @andrewseguin.

@andrewseguin andrewseguin merged commit 549d622 into angular:master Jun 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sanity checks from CompatibilityModule to MdCommonModule
4 participants
@crisbeto @andrewseguin @jelbourn @googlebot