Skip to content

Move sanity checks from CompatibilityModule to MdCommonModule #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jelbourn opened this issue Jun 6, 2017 · 1 comment · Fixed by #4987
Closed

Move sanity checks from CompatibilityModule to MdCommonModule #4979

jelbourn opened this issue Jun 6, 2017 · 1 comment · Fixed by #4987
Assignees
@crisbeto
Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent refactoring This issue is related to a refactoring

Comments

@jelbourn
Copy link
Member

jelbourn commented Jun 6, 2017

We originally used CompatibilityModule because ti was already included everywhere, but now we have CommonModule which is a better place for these checks.
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent refactoring This issue is related to a refactoring labels Jun 6, 2017
@crisbeto crisbeto self-assigned this Jun 6, 2017
@crisbeto crisbeto added the has pr label Jun 6, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 6, 2017
@crisbeto
chore: move sanity checks to common module
f4e6995 
Moves the sanity checks to the `MdCommonModule`.

Fixes angular#4979.
@crisbeto crisbeto mentioned this issue Jun 6, 2017
Merged
andrewseguin pushed a commit that referenced this issue Jun 8, 2017
@crisbeto @andrewseguin
chore: move sanity checks to common module (#4987)
549d622 
* chore: move sanity checks to common module

Moves the sanity checks to the `MdCommonModule`.

Fixes #4979.

* chore: re-export sanity checks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent refactoring This issue is related to a refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move sanity checks to common module crisbeto/material2
2 participants
@jelbourn @crisbeto