Skip to content

fix(slide-toggle) disabled state from a FormControl not updating #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

When setting the disabled state of a slide-toggle using the FormControl's enable() and disable() methods the slide-toggle's view won't be updated properly.

Fixes #4774

When setting the disabled state of a slide-toggle using the FormControl's `enable()` and `disable()` methods the slide-toggle's view won't be updated properly.

Fixes angular#4774
@devversion devversion requested a review from mmalerba May 25, 2017 12:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 25, 2017
@andrewseguin andrewseguin merged commit a9ad62d into angular:master Jun 5, 2017
@devversion devversion deleted the fix/slide-toggle-disabled-state branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After enable() slide toggles sometimes remain partially disabled
4 participants