test: fix infinite loop in tests #4662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some unit tests going into an infinite loop by using the `jasmine.any` matcher. Not exactly sure what is going on, but it was most likely introduced in Jasmine 2.6.2. For now I've replaced those matches with `instanceof` checks which accomplish the same. Fixes angular#4654.
crisbeto
changed the title
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto Thank you. |
|
@crisbeto Curious as to why the Travis CI build didn't fail? Looking at the Travis logs on some of the recent commits it doesn't list a job with MODE=test like you see with MODE=e2e? |
|
My guess is that it had a slightly older version of Jasmine in the cache, which wasn't problematic. At the time I submitted the PR, Jasmine 2.6.2 had been released for about 20 hours. |
googlebot
added
the
cla: yes
|
Nice 😄 I was wondering why I get out-of-memory issues on Chrome. |
This was referenced May 21, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some unit tests going into an infinite loop by using the
jasmine.anymatcher. Not exactly sure what is going on, but it was most likely introduced in Jasmine 2.6.2. For now I've replaced those matches withinstanceofchecks which accomplish the same.Fixes #4654.