fix(material/menu): add filter for trigger icon name #32188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the option to filter harnesses based on the icon in the menu trigger. Fixes angular#32181.
crisbeto
requested review from
tjshiu and
wagnermaciel
and removed request for
a team
ok7sai
approved these changes
Oct 28, 2025
Member
Author
crisbeto
added a commit
that referenced
this pull request
Oct 28, 2025
crisbeto
added a commit
that referenced
this pull request
Oct 28, 2025
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 15, 2025
Updates how we query for the icon to align with angular#32188. While implementing angular#32188, I was getting errors in some cases when the icons are missing.
crisbeto
added a commit
that referenced
this pull request
Nov 16, 2025
crisbeto
added a commit
that referenced
this pull request
Nov 16, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to filter harnesses based on the icon in the menu trigger.
Fixes #32181.