Skip to content

fix(material/chips): strengthen edit/remove icons focus/hover styling #31759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/chips): strengthen edit/remove icons focus/hover styling #31759

wants to merge 1 commit into from

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Aug 22, 2025 •
edited
Loading

Fixes b/286103414 by doubling the opacity of the edit and remove icons when they are focused and hovered, to provide more contrast against the chip which has the same opacity added on focus/hover.

@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit requires: TGP This PR requires a passing TGP before merging is allowed docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Aug 22, 2025
@adolgachev adolgachev marked this pull request as ready for review August 22, 2025 03:56
@adolgachev adolgachev requested a review from a team as a code owner August 22, 2025 03:56
@adolgachev adolgachev requested review from andrewseguin and wagnermaciel and removed request for a team August 22, 2025 03:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Deployed dev-app for 1d5ca15 to: https://ng-dev-previews-comp--pr-angular-components-31759-dev-61xov1fi.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Deployed docs-preview for 1d5ca15 to: https://ng-dev-previews-comp--pr-angular-components-31759-docs-6rzp9mji.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev force-pushed the chips-icon-focus branch 2 times, most recently from 070397b to d0db71f Compare August 22, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: global presubmit The PR is in need of a google3 global presubmit action: review The PR is still awaiting reviews from at least one requested reviewer area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adolgachev