Skip to content

fix(cdk/schematics): support project index file discovery for object-form and default #30967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 28, 2025

The project index file discovery process now supports finding paths for projects that use the object-form of the index field and also for projects that do not explicitly specify an index. Starting with v20, the index field will default to <project_source_root>/index.html if not present in the build options for the application build system.

…form and default

The project index file discovery process now supports finding paths for
projects that use the object-form of the `index` field and also for projects
that do not explicitly specify an index. Starting with v20, the index field
will default to `<project_source_root>/index.html` if not present in the
build options for the `application` build system.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 28, 2025
@angular-robot angular-robot bot added the area: cdk/schematics cdk/schematics is *not* a public API label Apr 28, 2025
@clydin clydin requested a review from crisbeto April 28, 2025 17:00
@clydin clydin marked this pull request as ready for review April 28, 2025 17:40
@clydin clydin requested a review from a team as a code owner April 28, 2025 17:40
@clydin clydin requested review from adolgachev and removed request for a team April 28, 2025 17:40
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I wonder if this shouldn't be a shared utility in the CLI.

@crisbeto crisbeto removed the request for review from adolgachev April 28, 2025 21:38
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2025
@crisbeto crisbeto merged commit 87501e8 into angular:main Apr 28, 2025
29 of 31 checks passed
@clydin clydin deleted the schematics/default-project-index branch April 28, 2025 21:43
wildcardalice pushed a commit to wildcardalice/components that referenced this pull request May 12, 2025
…form and default (angular#30967)

The project index file discovery process now supports finding paths for
projects that use the object-form of the `index` field and also for projects
that do not explicitly specify an index. Starting with v20, the index field
will default to `<project_source_root>/index.html` if not present in the
build options for the `application` build system.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/schematics cdk/schematics is *not* a public API target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants