Skip to content

chore(autocomplete): Add autocomplete exports to the index.ts. #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Feb 5, 2017

Using the latest nightly build in https://github.com/angular/material2-builds there wasnt a way to import only the MdAutocompleteModule nor its components from @angular/material because it wasnt in the index.ts file.

Looked at the opened PR's and didnt see it in them either, so just creating this PR just in case (Also a nice way to do my first little contribution 😄)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Feb 5, 2017
@emoralesb05
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Feb 5, 2017
@emoralesb05 emoralesb05 changed the title feat(autocomplete): Add autocomplete exports to the index.ts. chore(autocomplete): Add autocomplete exports to the index.ts. Feb 5, 2017
@emoralesb05 emoralesb05 force-pushed the autocomplete-export branch 3 times, most recently from be7eed7 to 8880007 Compare February 5, 2017 04:01
add a way to import the autocomplete module and components from @angular/material
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 7, 2017
@tinayuangao tinayuangao merged commit 8b83dcc into angular:master Feb 9, 2017
@emoralesb05 emoralesb05 deleted the autocomplete-export branch February 9, 2017 18:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants