Skip to content

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 4, 2017

Updates the selector for mdInput within md-input-container to match other attribute directives.

@kara kara requested review from jelbourn and mmalerba January 4, 2017 02:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 4, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 4, 2017
@kara kara merged commit 93b0bc9 into angular:master Jan 4, 2017
@francisoud
Copy link

You should add a "breaking change" mention the changelog to tell people that they need to update from md-input to mdInput when moving from 2.0.0-beta.1 to the next version... otherwise they will discover it the 'hard way' ;)
I don't see any documentation change in 93b0bc9

@mmalerba
Copy link
Contributor

@francisoud I think the README was updated as part of this pr, but you're right we should call this out in the changelog for the next release, thank you for the reminder.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants