refactor(material/datepicker): unit test with not the first of the month #24401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only affects the unit tests and doesn't not affect application code. It's a small improvement to the unit tests in the multi-year view to use Jan 3 instead of Jan 1. This can catch more bugs because we could catch that we're setting a date to the first of the month when we're not supposed to.
zarend
added
merge safe
target: patch
wagnermaciel
pushed a commit
that referenced
this pull request
Feb 15, 2022
…nth (#24401) This change only affects the unit tests and doesn't not affect application code. It's a small improvement to the unit tests in the multi-year view to use Jan 3 instead of Jan 1. This can catch more bugs because we could catch that we're setting a date to the first of the month when we're not supposed to. (cherry picked from commit f0ebd2a)
zarend
added a commit
to zarend/components
that referenced
this pull request
Feb 15, 2022
Fixes a failing unit test, which was referencing Jan 1, 2017 as the initial date when it is actually Jan 3, 2017. This happened as a result of a bad merge where angular#24384 changed the initial date to Jan 3, and angular#24401 added a new test that assume the initial date was Jan 1.
zarend
added a commit
to zarend/components
that referenced
this pull request
Feb 15, 2022
Fixes a failing unit test, which was referencing Jan 1, 2017 as the initial date when it is actually Jan 3, 2017. This happened as a result of a bad merge where angular#24384 changed the initial date to Jan 3, and angular#24401 added a new test that assume the initial date was Jan 1.
zarend
added a commit
to zarend/components
that referenced
this pull request
Feb 15, 2022
Fix a failing unit test, which was referencing Jan 1, 2017 as the initial date when it is actually Jan 3, 2017. This happened as a result of a bad merge where angular#24384 changed the initial date to Jan 3, and angular#24401 added a new test that assume the initial date was Jan 1. Fixes CI failure
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…nth (angular#24401) This change only affects the unit tests and doesn't not affect application code. It's a small improvement to the unit tests in the multi-year view to use Jan 3 instead of Jan 1. This can catch more bugs because we could catch that we're setting a date to the first of the month when we're not supposed to.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects the unit tests and doesn't not affect
application code. It's a small improvement to the unit tests in the
multi-year view to use Jan 3 instead of Jan 1. This can catch more bugs
because we could catch that we're setting a date to the first of the
month when we're not supposed to.