Skip to content

fix(material-experimental/mdc-select): change max height to show scrollability #24129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(material-experimental/mdc-select): change max height to show scrollability #24129

merged 1 commit into from
Jan 7, 2022

Conversation

crisbeto
Copy link
Member

Increases the maximum height of the MDC-based select panel in order to partially show the next option so that it is easier to see when the panel is scrollable.

Related to b/211518654.

@crisbeto
fix(material-experimental/mdc-select): change max height to show scro…
65f5d66 
…llability

Increases the maximum height of the MDC-based select panel in order to partially show the next option so that it is easier to see when the panel is scrollable.

Related to b/211518654.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 22, 2021
@crisbeto crisbeto requested a review from mmalerba December 22, 2021 09:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
mmalerba
mmalerba approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 4, 2022
@wagnermaciel wagnermaciel merged commit 557ac0d into angular:master Jan 7, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 7, 2022
@crisbeto @wagnermaciel
fix(material-experimental/mdc-select): change max height to show scro…
eb508be 
…llability (#24129)

Increases the maximum height of the MDC-based select panel in order to partially show the next option so that it is easier to see when the panel is scrollable.

Related to b/211518654.

(cherry picked from commit 557ac0d)
zarend pushed a commit to zarend/components that referenced this pull request Jan 7, 2022
@crisbeto @zarend
fix(material-experimental/mdc-select): change max height to show scro…
15ef260 
…llability (angular#24129)

Increases the maximum height of the MDC-based select panel in order to partially show the next option so that it is easier to see when the panel is scrollable.

Related to b/211518654.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel